Skip to content

Issue #15514 - Avoid duplicate lifecycle failure logging - #15521

Open
DragonFSKY wants to merge 1 commit into
jetty:jetty-12.1.xfrom
DragonFSKY:fix-15514-ssl-load-warning
Open

Issue #15514 - Avoid duplicate lifecycle failure logging#15521
DragonFSKY wants to merge 1 commit into
jetty:jetty-12.1.xfrom
DragonFSKY:fix-15514-ssl-load-warning

Conversation

@DragonFSKY

@DragonFSKY DragonFSKY commented Jul 31, 2026

Copy link
Copy Markdown

Removes the legacy failure WARN from AbstractLifeCycle, which was emitted only when DEBUG logging was enabled and could duplicate startup failure reporting.

Exceptions continue to propagate unchanged, the lifecycle still transitions to FAILED, and listeners receive the same failure cause. The lifecycle tests now assert those behaviors directly.

Fixes #15514.

@olamy

olamy commented Jul 31, 2026

Copy link
Copy Markdown
Member

@DragonFSKY thanks for the PR. You might need to register ECA at Eclipse. Thanks

@DragonFSKY

Copy link
Copy Markdown
Author

@olamy Thanks for the reminder. I’ve signed the Eclipse Contributor Agreement and linked my GitHub account. The ECA check is now passing.

@sbordet sbordet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right approach, see comment in #15514.

@stefano-1973

stefano-1973 commented Aug 1, 2026

Copy link
Copy Markdown

I don't think this is the right approach, see comment in #15514.

If you read my reply to sbordet in comment #15514, I think that your pr is good and the suggestion of sborder is not correct for all the situations.

@DragonFSKY
DragonFSKY force-pushed the fix-15514-ssl-load-warning branch from d70e2af to 10cf478 Compare August 2, 2026 00:56
@DragonFSKY DragonFSKY changed the title Issue #15514 - Log SSL context load failures Issue #15514 - Avoid duplicate lifecycle failure logging Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning message is logged only if isDebugEnabled in AbstractLifeCycle. Is it wanted?

4 participants